This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add review rules regarding the owned files #14122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juangirini
added
A0-please_review
juangirini
changed the title
juangirini
commented
May 11, 2023
.github/pr-custom-review.yml
Outdated
| - name: FRAME coders | ||
| check_type: changed_files | ||
| condition: | ||
| include: ^frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*)) |
There was a problem hiding this comment.
This line includes everything under frame expect for those named sub directories, or partially named ones (beef will match beefy and beefy-mmr)
@kianenigma @ggwpez do you think there's more we want to exclude?
|
bot rebase |
|
Rebased |
alvicsam
approved these changes
May 16, 2023
rcny
approved these changes
May 16, 2023
|
bot rebase |
|
Rebased |
sam0x17
approved these changes
May 16, 2023
sergejparity
approved these changes
May 16, 2023
|
bot merge |
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
* Add FRAME Coders PR rule * change regexp rule from `beef` to `beefy` * exclude pallet-aura from frame coders rule --------- Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Add FRAME Coders PR rule * change regexp rule from `beef` to `beefy` * exclude pallet-aura from frame coders rule --------- Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #13791
This PR adds a new Custom Review rule for code owned by the @paritytech/frame-coders team.