Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump libp2p to fix the broken Polkadot companions #6554

Closed
wants to merge 3 commits into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 2, 2020

Updates everything

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 2, 2020
@tomaka tomaka requested a review from mxinden as a code owner July 2, 2020 08:11
@tomaka tomaka added the A1-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix label Jul 2, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Jul 2, 2020

cc @s3krit The "burn-in" notification script failed.

@tomaka tomaka added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jul 2, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Jul 2, 2020

I opened this PR eagerly and optimistically, with the idea that the CI runs in parallel of the Riot discussions.
Since the problem has been solved by yanking libp2p-websocket 0.20.1, we can delay this update.

@tomaka tomaka closed this Jul 2, 2020
@tomaka tomaka deleted the bump-libp2p branch July 2, 2020 10:11
@s3krit
Copy link
Contributor

s3krit commented Jul 2, 2020

cc @s3krit The "burn-in" notification script failed.

I know this PR is now closed, but thanks for the heads up :) Confirming we've got the right secrets configured in the repo

@s3krit
Copy link
Contributor

s3krit commented Jul 2, 2020

cc @s3krit The "burn-in" notification script failed.

Figured this out. As per Github's docs:

Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more.

So it's working as intended.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A1-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants