This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix deprecated usage of panic #8134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A2-insubstantial
kianenigma
approved these changes
Feb 16, 2021
ascjones
reviewed
Feb 16, 2021
| @@ -320,7 +320,7 @@ where | |||
| ) { | |||
| extrinsics.into_iter().for_each(|e| if let Err(e) = Self::apply_extrinsic(e) { | |||
| let err: &'static str = e.into(); | |||
| panic!(err) | |||
| panic!("{}", err) | |||
There was a problem hiding this comment.
Doesn't the error implement Display itself?
Edit: It does but only in std
substrate/primitives/runtime/src/transaction_validity.rs
Lines 201 to 202 in 9b08105
There was a problem hiding this comment.
yeah only on "std", I guess we can implement display on on not(std) as well
ascjones
approved these changes
Feb 16, 2021
bkchr
approved these changes
Feb 16, 2021
KalitaAlexey
pushed a commit
to KalitaAlexey/substrate
that referenced
this pull request
Jul 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to rust-lang/rust#81645 panic now seems to requrie a string literal as first argument, thus the fix.