This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix transaction payment fee/tip unbalanceds #8860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
B3-apinoteworthy
C1-low
bkchr
reviewed
May 19, 2021
Comment on lines
+727
to
+730
| impl OnUnbalanced<pallet_balances::NegativeImbalance<Runtime>> for DealWithFees { | ||
| fn on_unbalanceds<B>( | ||
| mut fees_then_tips: impl Iterator<Item=pallet_balances::NegativeImbalance<Runtime>> | ||
| ) { |
There was a problem hiding this comment.
Could we not make this "smarter", aka better.
trait OnUnbalanced<V, R> where R: IntoIterator<Item=V> {
fn on_unbalanceds<B>(whatever: R) {}
}
So we could have:
struct TransactionPayment {
pub fees,
pub tips,
}
Than we could in DealWithFees directly use this struct? While others could still use the generic approach with the iterator?
Do you understand what I want to do? :D
There was a problem hiding this comment.
And R would be TransactionPayment
There was a problem hiding this comment.
opened this issue https://github.com/paritytech/substrate/issues/8861
gavofyork
approved these changes
May 19, 2021
|
Merging for now since it's an important one. Can refactor in a second PR. |
sorpaas
added a commit
to neatcoin/neatcoin
that referenced
this pull request
May 20, 2021
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* fix and test * fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8854
contrary to the doc, the on unbalanced handler is given the tip first and then the fee. This PR fix it, and test it.