Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(txwrapper-polkadot): Add crowdloan.addMemo #99

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Jun 2, 2021

This PR adds crowdloan.addMemo to @substrate/txwrapper-polkadot.

Internal changes:

  • Deprecate the westend v50 static metadata and instead for use v9030. This is necessary to get metadata with the addMemo pallet method for testing. This also results in the call pallet/call indexes changing and thus a small diff in the spec for other crowdloan methods.

Note: this has not been tested against a dev chain, so it would be helpful if a reviewer could quickly sanity test the new method.

closes #98

@emostov emostov requested review from TarikGul and dvdplm June 2, 2021 01:03
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally against westend-local. author_submitExtrinsic had no issues getting the transaction in the block.

Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't verify the magic values, but code LGTM.

@TarikGul TarikGul merged commit 0b305ec into main Jun 2, 2021
@TarikGul TarikGul deleted the zeke-crowdloan-addmemo branch June 2, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add crowdloan.addMemo to txwrapper-polkadot
3 participants