Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (synology) allow https webhook for surveillance #199

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

kevinchan123456
Copy link

request will check SSL cerificate authorities. The only way to let our middleware support HTTPS before this commit was using DDNS. After internal discussions, we prefer to set the property 'verify' to False.

The reason we can't use HTTPS is that our NAS devices are using self-signed certificates.

Copy link
Collaborator

@danleyb2 danleyb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcbelmont marcbelmont merged commit 2886945 into parkpow:master Apr 15, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants