Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic question from a novice: Truncated example.js output #40

Closed
iannecj opened this issue Jul 15, 2020 · 6 comments
Closed

Basic question from a novice: Truncated example.js output #40

iannecj opened this issue Jul 15, 2020 · 6 comments
Labels
invalid This doesn't seem right question Further information is requested

Comments

@iannecj
Copy link

iannecj commented Jul 15, 2020

when I first used this example function months ago I saw the full result to console. Now when I run the example I see only the result of the first get equipment config only. What am I missing? I dont see in example anything that would prevent the subsequent functions to display their data to console.

C:\Users\Chris\Desktop\node_screenlogic\node_modules\node-screenlogic>node example
version = 1180
secondaries = 0
pump 1 type=0, pump 2 type=2
pump 1 pool rpm=2000
pump 2 waterfall rpm=0
num pumps=7

C:\Users\Chris\Desktop\node_screenlogic\node_modules\node-screenlogic>

@parnic
Copy link
Owner

parnic commented Jul 15, 2020

Can you share a gist or something with your example.js contents? Are you sure you're still on the correct remote? secondaries = # isn't in the example.js that's in the repo, so it should not be able to print that.

Additionally, it looks like you've got node-screenlogic stored as a node module under node_screenlogic, which is also odd. Make sure your environment is setup the way you expect it to be (npm install from a clean node-screenlogic sync shouldn't cause it to install itself as a node module).

@parnic parnic added invalid This doesn't seem right question Further information is requested labels Jul 15, 2020
@iannecj
Copy link
Author

iannecj commented Jul 15, 2020 via email

@iannecj
Copy link
Author

iannecj commented Jul 15, 2020 via email

@parnic
Copy link
Owner

parnic commented Jul 15, 2020

Okay, I don't know how npm is getting the files it's getting, then, because node-screenlogic shouldn't be a module under node-screenlogic. Regardless, this is why your example output is what it is:

  client.on('loggedIn', function() {
    // this.getVersion();
    // this.getControllerConfig();

    this.getEquipmentConfiguration();

This is the version from the repository that you should be seeing: https://github.com/parnic/node-screenlogic/blob/main/example.js

You should probably look into some npm docs if that's where the problem is originating. You may want to see if there's a copy of the repo at C:\Users\Chris\Desktop\node_screenlogic instead of diving into node_modules first. But just cloning this repository directly should show you the example output you're expecting to see.

@parnic parnic closed this as completed Jul 15, 2020
@parnic
Copy link
Owner

parnic commented Jul 16, 2020

Okay, I figured out how that example.js got onto npm and have published a new version, 1.6.0-1, that contains the expected example.js.

@iannecj
Copy link
Author

iannecj commented Jul 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants