Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed installation of libqalculatenasc.so (again) #57

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

Mailaender
Copy link
Contributor

The same fix from #47 after it regressed in #56.

@Mailaender
Copy link
Contributor Author

See https://build.opensuse.org/package/show/X11:Pantheon/nasc for an integration test.

@parnoldx
Copy link
Owner

Hi. I reverted it because it doesn't build with that on launchpad and locally here. I not really know cmake so don't know why.

@Mailaender
Copy link
Contributor Author

Try to build with cmake -DCMAKE_INSTALL_LIBDIR=/usr/lib then, but I guess Ubuntu has it's own set of macros which take care of that automatically.

@Mailaender
Copy link
Contributor Author

@parnoldx
Copy link
Owner

It builds with that locally. Great. But still there is the problem with launchpad.

@phw
Copy link
Contributor

phw commented Sep 27, 2017

For launchpad something like this in debian/rules could fix it:

override_dh_auto_configure:
	dh_auto_configure -- -DCMAKE_INSTALL_LIBDIR=/usr/lib

@parnoldx
Copy link
Owner

@phw Thanks a lot. Will try this.

@parnoldx parnoldx merged commit 13a74f6 into parnoldx:nasc Sep 27, 2017
@phw phw mentioned this pull request Sep 28, 2017
@Mailaender Mailaender deleted the patch-1 branch September 28, 2017 20:02
@nick87720z
Copy link
Contributor

nick87720z commented May 11, 2018

Hello, again right this bug (or almost this). CMAKE_INSTALL_LIBDIR doesn't work.
Right after configuration i can open build/libqalculatenasc/cmake_install.cmake and see this:

$ grep -nRF '${CMAKE_INSTALL_PREFIX}/lib'
libqalculatenasc/cmake_install.cmake:36:  if(EXISTS "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/libqalculatenasc.so" AND
libqalculatenasc/cmake_install.cmake:37:     NOT IS_SYMLINK "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/libqalculatenasc.so")
libqalculatenasc/cmake_install.cmake:39:         FILE "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/libqalculatenasc.so"
libqalculatenasc/cmake_install.cmake:42:  file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/lib" TYPE SHARED_LIBRARY FILES "/home/nick87720z/dist/nasc/build/libqalculatenasc/libqalculatenasc.so")
libqalculatenasc/cmake_install.cmake:43:  if(EXISTS "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/libqalculatenasc.so" AND
libqalculatenasc/cmake_install.cmake:44:     NOT IS_SYMLINK "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/libqalculatenasc.so")
libqalculatenasc/cmake_install.cmake:46:      execute_process(COMMAND "/usr/bin/strip" "$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/lib/libqalculatenasc.so")

Looking to ccmake, LIB_SUFFIX=64 and CMAKE_INSTALL_LIBDIR=lib64.
I can't find, from where it goes.

Yet, mentioned search phrase doesn't appear anywhere in source tree (in any cmake files).
From sources dir: https://gist.github.com/nick87720z/57638d5899dc3f3fe8550310eee98240

Again update :)
libqalculatenasc/CMakeLists.txt:9:install (TARGETS qalculatenasc LIBRARY DESTINATION lib)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants