Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-204: cleanup definitions in db before loading new beans #146

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

RichardW98
Copy link
Contributor

@RichardW98 RichardW98 commented Mar 22, 2023

FLPATH-204

update database with new workflow configuration after app restarts

*note: executions and project table are not cleaned

Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please add a test

@RichardW98
Copy link
Contributor Author

tests added

@masayag
Copy link
Collaborator

masayag commented Mar 22, 2023

What will happen if there are tasks execution or workflow execution in the DB ? Wouldn't it cause reference key constrain violation?
Perhaps there is a need to check there are not executions of any kind before deleting?

@RichardW98
Copy link
Contributor Author

What will happen if there are tasks execution or workflow execution in the DB ? Wouldn't it cause reference key constrain violation? Perhaps there is a need to check there are not executions of any kind before deleting?

yes, the executions will be deleted as well if its definition is removed. I will change the logic from removing definitions to updating/adding

@eloycoto
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloycoto, RichardW98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pkliczewski
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 176a825 into parodos-dev:main Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants