FLPATH-207: Add IN_PROGRESS Work Status #184
Conversation
|
/jira refresh |
|
@nirarg: This pull request references FLPATH-207 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/lgtm |
| @@ -258,7 +258,7 @@ private WorkReport handlePostWorkflowExecution(boolean isMaster, WorkFlowExecuti | |||
| || !WorkFlowStatus.COMPLETED.equals(checkerExecution.getStatus()))) { | |||
| log.info("fail workflow: {} because it has pending/running checker(s)", workFlowDefinition.getName()); | |||
| workFlowExecution.setStatus(WorkFlowStatus.PENDING); | |||
| report = new DefaultWorkReport(WorkStatus.FAILED, workContext); | |||
| report = new DefaultWorkReport(WorkStatus.IN_PROGRESS, workContext); | |||
There was a problem hiding this comment.
in_progress won't stop the workflow to wait for checker : https://github.com/parodos-dev/parodos/blob/main/workflow-engine/src/main/java/com/redhat/parodos/workflows/workflow/SequentialFlow.java#L62
There was a problem hiding this comment.
but this pr is very meaningful as the status enums in workflow-engine is apparently not enough.
There was a problem hiding this comment.
Oh, great catch
So maybe can check there that status is not completed (instead of checking equals to FAILED)
What do you say?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RichardW98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In case of Checker not completed return IN_PROGRESS status instead of FAILED