Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-207: Add IN_PROGRESS Work Status #184

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

nirarg
Copy link
Contributor

@nirarg nirarg commented Mar 30, 2023

In case of Checker not completed return IN_PROGRESS status instead of FAILED

@nirarg
Copy link
Contributor Author

nirarg commented Mar 30, 2023

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 30, 2023

@nirarg: This pull request references FLPATH-207 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@masayag
Copy link
Collaborator

masayag commented Mar 30, 2023

/lgtm

@pkliczewski
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 30, 2023
@@ -258,7 +258,7 @@ private WorkReport handlePostWorkflowExecution(boolean isMaster, WorkFlowExecuti
|| !WorkFlowStatus.COMPLETED.equals(checkerExecution.getStatus()))) {
log.info("fail workflow: {} because it has pending/running checker(s)", workFlowDefinition.getName());
workFlowExecution.setStatus(WorkFlowStatus.PENDING);
report = new DefaultWorkReport(WorkStatus.FAILED, workContext);
report = new DefaultWorkReport(WorkStatus.IN_PROGRESS, workContext);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this pr is very meaningful as the status enums in workflow-engine is apparently not enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great catch
So maybe can check there that status is not completed (instead of checking equals to FAILED)
What do you say?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anludke @lshannon please suggest if we can modify base workflow-engine library, and change its logic of "completed" for all types of workflow, e.g parallel, conditional, repeat, sequential ....

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichardW98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants