add ui schema property to scaffolder templates #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the ui:autofocus is something that currently the UI already does automatically for the first property of each step ui:widget: textarea |
batzionb
reviewed
Sep 1, 2024
| @@ -7,7 +7,8 @@ | |||
| "sampleText": { | |||
| "title": "A sample text", | |||
| "type": "string", | |||
| "description": "Sample text data" | |||
| "description": "Sample text data", | |||
| "ui:autofocus": true | |||
There was a problem hiding this comment.
Suggested change
| "ui:autofocus": true | |
| "ui:widget": "textarea" |
batzionb
reviewed
Sep 1, 2024
| @@ -38,6 +38,9 @@ instance of the ${{ values.workflowId }} workflow: | |||
| curl -v -X POST -H "Content-Type: application/json" http://localhost:8080/${{ values.workflowId }} -d@input.json | |||
| ``` | |||
|
|
|||
| ## Adding UI schema properties | |||
| You can add React UI schema properties to the input schema. See the 'ui:autofocus' example at [${{ values.artifactId }}-schema.json](./src/main/resources/schemas/${{ values.artifactId }}-schema.json ). | |||
There was a problem hiding this comment.
Suggested change
| You can add React UI schema properties to the input schema. See the 'ui:autofocus' example at [${{ values.artifactId }}-schema.json](./src/main/resources/schemas/${{ values.artifactId }}-schema.json ). | |
| You can add React UI schema properties to the input schema. See the 'ui:widget' example at [${{ values.artifactId }}-schema.json](./src/main/resources/schemas/${{ values.artifactId }}-schema.json ). |
batzionb
approved these changes
Sep 2, 2024
batzionb
approved these changes
Sep 2, 2024
|
/lgtm |
|
/approve |
FLPATH-1615 https://issues.redhat.com/browse/FLPATH-1615 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
|
New changes are detected. LGTM label has been removed. |
ydayagi
changed the title
masayag
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLPATH-1615
https://issues.redhat.com/browse/FLPATH-1615