-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Titanfall 2 X-box One controller unsupported #57
Comments
Additional info from
|
Been debugging this a little on my own, although I'm way over my head. I turned on verbose debugging and it looks like it's sending the following two lines over and over again:
Is this an attempt at a handshake? |
Try this, or compare it to what you have. It's just adding the id for your controller. https://github.com/dantob/xpad/commit/0098e8af630614843451cc12d20cdc75f62cd3b0 |
Yea I had added it correctly but in the info I had posted, I had already begun the debugging process and was trying to follow the detection code for generic pads. Neither path bore fruit, however, and both recognize the controller but does not accept inputs. To be more add some detail, I tried adding my line both with Xbox one and Xbox 360 types manually specified (and verified the string was present in jstest) and additionally reverted those changes and found no discernible difference between the three. |
Try this commit https://github.com/dantob/xpad/commit/fd9d3d906e74ef8a480ce5aa3ecfda2247b20993 and make sure the device is being sent the initialize packet;
|
After the initial send line, it just repeats the other two lines over and over ad infinitum. |
@powersurge360 Can you give this xpad.c a shot? http://pastebin.com/raw/dAFC3R5q Apologies in advance for not pushing this up to GitHub properly yet. I've added a second init packet that the macOS Xbox Driver project 360Controller uses. Edit: Changed the link to v2 to remove a WARN_ON_ONCE that was a bit to aggressive. |
This corrected the issue for me! Woot woot. Is there anything I ought to turn off for this particular file? Is it in debug mode or in any other way unstable that I should be concerned about? |
Are you using the v2 link or did you get the original (before I edited it)? Do you see anything nasty in dmesg? |
I used first one and then the other. I don't notice anything awry in dmesg for either file. |
Then you should be fine. It's the current xpad.c queued for 4.10-rc2 plus that init change. I'll prepare a patch for upstream. |
Thanks for debugging my hardware you two! I was so heartbroken that my nice new controller wasn't working A+ open sourcing :) |
hmm.. we already had that packet once in #20 - go figure.. |
see #57 Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
@powersurge360 Can you confirm that your pads still work with this xpad.c? http://pastebin.com/raw/Re8xby26 |
@cgutman could you please in future provide test code via a fork of this repo where one can see the diff? |
@paroj I agree I was being a bit lazy. I've setup a fork with the code - https://github.com/cgutman/xpad/tree/3rdparty |
@powersurge360 If you're still willing to test, can you confirm that the issue remains fixed on my "for_upstream" branch? https://github.com/cgutman/xpad If that works, may I add a "Tested-By: Firstname Lastname Email address" from you for my submission upstream? |
see #57 Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
My device only works with "powera" branch and neither "3rdparty" nor "for_upstream". |
Hey! I hope I've captured enough info to be useful, but please let me know if you need more.
Here's what
lsusb -v
has to say about the device.I was optimistic that I could simply add the product to the
xpad_device
array and specify that it is an xbox one controller but no dice. The controller is recognized but the inputs are not. Let me know anyway I can help, I'd like to get this guy set up as soon as possible!The text was updated successfully, but these errors were encountered: