Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds httpoison ~> 2.0 support #196

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

antedeguemon
Copy link
Contributor

@antedeguemon antedeguemon commented Feb 9, 2023

Hey there! 🖖

This PR simply loosens the httpoison ~> 1.0 constraint.

The breaking changes from httpoison 1.8.2 to 2.0 are related to SSL options - which are not used by exvcr. Therefore, loosening the constraint shouldn't have any collateral effect on exvcr.

For more details about the breaking changes, see httpoison 2.0.0 release.

Closes #195

@coveralls
Copy link

coveralls commented Feb 12, 2023

Coverage Status

Coverage: 88.784%. Remained the same when pulling fc2ea29 on antedeguemon:vm-adds-httpoison-2.0-support into 2204e8f on parroty:master.

@coveralls
Copy link

Coverage Status

Coverage: 90.363% (+1.6%) from 88.784% when pulling fc2ea29 on antedeguemon:vm-adds-httpoison-2.0-support into 2204e8f on parroty:master.

@parroty parroty merged commit 23900f2 into parroty:master Feb 12, 2023
@parroty
Copy link
Owner

parroty commented Feb 12, 2023

Thanks!

1 similar comment
@nathany-copia
Copy link

Thanks!

@antedeguemon antedeguemon deleted the vm-adds-httpoison-2.0-support branch February 13, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support httpoison 2.0
4 participants