Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idempotency error "duplicate request" #1189

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 4, 2020

Adds new Parse Error 159: DUPLICATE_REQUEST.

This PR completes the server side implementation of parse-community/parse-server#6748.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #1189 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          54       54           
  Lines        5293     5294    +1     
  Branches     1191     1191           
=======================================
+ Hits         4888     4889    +1     
  Misses        405      405           
Impacted Files Coverage Δ
src/ParseError.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d432259...4f7022b. Read the comment docs.

@mtrezza mtrezza requested review from dplewis and SebC99 July 4, 2020 17:03
@SebC99
Copy link
Contributor

SebC99 commented Jul 5, 2020

I love the idea, especially for "long" requests. Not sure how the clients will have to be adapted to silently cope with this error, so we have to mark it as breaking change:
Before this, there was no error, just duplicates results... and now it will result in an error for all the duplicate calls.

@mtrezza
Copy link
Member Author

mtrezza commented Jul 5, 2020

I love the idea, especially for "long" requests. Not sure how the clients will have to be adapted to silently cope with this error, so we have to mark it as breaking change: Before this, there was no error, just duplicates results... and now it will result in an error for all the duplicate calls.

@SebC99 This is not a breaking change. This PR merely adds an error code and occupies the currently unused error code 159 for that matter. This is part of an experimental feature that can be turned on / off. Even when it matures out of experimental status it should not be on by default due to the overhead it incurs, so I assume at this point that this will never be a breaking change.

@SebC99
Copy link
Contributor

SebC99 commented Jul 5, 2020

👌

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit 22d2925 into parse-community:master Jul 9, 2020
@mtrezza mtrezza deleted the add-idempotency branch October 26, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants