-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add idempotency error "duplicate request" #1189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 54 54
Lines 5293 5294 +1
Branches 1191 1191
=======================================
+ Hits 4888 4889 +1
Misses 405 405
Continue to review full report at Codecov.
|
I love the idea, especially for "long" requests. Not sure how the clients will have to be adapted to silently cope with this error, so we have to mark it as breaking change: |
@SebC99 This is not a breaking change. This PR merely adds an error code and occupies the currently unused error code |
👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds new Parse Error 159:
DUPLICATE_REQUEST
.This PR completes the server side implementation of parse-community/parse-server#6748.