Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for FacebookUtils #779

Merged
merged 6 commits into from
Apr 2, 2019
Merged

Add test cases for FacebookUtils #779

merged 6 commits into from
Apr 2, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 2, 2019

Improve documentation for link and logIn. Minor clean up

Improves coverage (no tests exists)

Flow types will be in a separate PR.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #779 into master will increase coverage by 1.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   90.57%   91.99%   +1.41%     
==========================================
  Files          54       54              
  Lines        4903     4897       -6     
  Branches     1088     1086       -2     
==========================================
+ Hits         4441     4505      +64     
+ Misses        462      392      -70
Impacted Files Coverage Δ
src/FacebookUtils.js 100% <100%> (+95.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02366c9...6fa80b5. Read the comment docs.

@dplewis dplewis merged commit ba6c448 into master Apr 2, 2019
@dplewis dplewis deleted the facebook-test branch April 2, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants