LDS: Improve Error Handling #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #773 Should we log key, values? Console.log vs warn vs error?
|
test failing |
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
+ Coverage 92.03% 92.05% +0.02%
==========================================
Files 54 54
Lines 4920 4922 +2
Branches 1092 1092
==========================================
+ Hits 4528 4531 +3
+ Misses 392 391 -1
Continue to review full report at Codecov.
|
|
@acinader After much trial and error, I discovered with the latest jest / jsdom you can't spy after mocking localStorage. It is already set in window.localStorage by jest. No need to mock it. Weird because every test I tried ran locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #773
Should we log key, values?
Console.log vs warn vs error?