Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParseBytes and ParsePolygon #190

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Add ParseBytes and ParsePolygon #190

merged 2 commits into from
Jul 10, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jul 10, 2021

Adds two missing Parse types to the Swift SDK: ParseBytes and ParsePolygon.

  • add ParseBytes
  • add ParsePolygon
  • (Breaking change) improve ParsePolygon by making the initializer throw if a geo point is out of bounds instead of asserting
  • fix withinPolygon(key: String, points: [ParseGeoPoint]) to make it send an array of doubles instead of an array of GeoPoint's
  • add withinPolygon(key: String, polygon: ParsePolygon)
  • add test cases
  • add playground examples

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #190 (f426531) into main (87c4367) will increase coverage by 0.23%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   82.63%   82.86%   +0.23%     
==========================================
  Files          71       73       +2     
  Lines        6823     6922      +99     
==========================================
+ Hits         5638     5736      +98     
- Misses       1185     1186       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseBytes.swift 94.44% <94.44%> (ø)
Sources/ParseSwift/Types/ParsePolygon.swift 96.00% <96.00%> (ø)
Sources/ParseSwift/Types/ParseGeoPoint.swift 98.36% <100.00%> (+0.02%) ⬆️
Sources/ParseSwift/Types/Query.swift 94.47% <100.00%> (+0.20%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 81.64% <0.00%> (+0.15%) ⬆️
Sources/ParseSwift/Coding/AnyEncodable.swift 61.84% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c4367...f426531. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant