Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate Keychain for each app #224

Merged
merged 3 commits into from
Sep 5, 2021
Merged

Use separate Keychain for each app #224

merged 3 commits into from
Sep 5, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Sep 4, 2021

Fixes an issue on macOS based ParseSwift apps where they end up using the same Keychain. This is fixed by using the app bundle id for the keychain of each app. The issue is explained here: #223 (comment)

Warning for macOS app developers only the user who logged in last to your app will have their Keychain upgraded to the patched version. Other users/apps will either need to login again or logout then login again

@cbaker6 cbaker6 linked an issue Sep 4, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #224 (e2a0622) into main (ba3d60e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head e2a0622 differs from pull request most recent head 015b197. Consider uploading reports for the commit 015b197 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   83.62%   83.68%   +0.06%     
==========================================
  Files          76       76              
  Lines        7284     7318      +34     
==========================================
+ Hits         6091     6124      +33     
- Misses       1193     1194       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/Parse.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Storage/KeychainStore.swift 98.16% <100.00%> (+0.41%) ⬆️
Sources/ParseSwift/Types/ParseVersion.swift 98.76% <100.00%> (+0.08%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 78.06% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3d60e...015b197. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Sep 4, 2021

@novemTeam can you try this branch out?

Be sure to checkout the warning

Warning for macOS app developers only the user who logged in last to your app will have their Keychain upgraded to the patched version. Other users/apps will either need to login again or logout then login again

@vdkdamian
Copy link
Contributor

@cbaker6 I tested it out, I logged out on both the apps, then logged back in. The problem is fixed.
I also tried running the app on iOS back again, just to be sure, and had no issues.

Seems like the issue is fixed with this branch.

@cbaker6 cbaker6 merged commit e1e5bd7 into main Sep 5, 2021
@cbaker6 cbaker6 deleted the keychainUpdates branch September 5, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple apps are running the same ParseUser
2 participants