Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ParsePush notifications #371

Merged
merged 36 commits into from
Jun 13, 2022
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 5, 2022

New Pull Request Checklist

Issue Description

The SDK currently can't send push notifications.

Related issue: #n/a

Approach

Enable APN and FCM push notifications in the SDK. This should only be used when taking advantage of the Swift SDK on a server. To enable this feature, Query is made to conform to Codable. Make QueryWhere public.

The are some bugs on the server the SDK codes around to make this feature possible:

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 5, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #371 (dcfe0bf) into main (c32e269) will increase coverage by 0.48%.
The diff coverage is 97.74%.

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   88.51%   89.00%   +0.48%     
==========================================
  Files         125      137      +12     
  Lines       12970    13402     +432     
==========================================
+ Hits        11481    11929     +448     
+ Misses       1489     1473      -16     
Impacted Files Coverage Δ
Sources/ParseSwift/API/Responses.swift 95.00% <ø> (ø)
Sources/ParseSwift/Parse.swift 98.77% <ø> (ø)
Sources/ParseSwift/Types/ParseAnalytics.swift 96.24% <ø> (-0.17%) ⬇️
Sources/ParseSwift/Types/ParseSchema+combine.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseSchema.swift 97.83% <ø> (ø)
Sources/ParseSwift/Types/Pointer.swift 98.41% <50.00%> (ø)
Sources/ParseSwift/Coding/AnyCodable.swift 65.71% <90.00%> (+6.69%) ⬆️
Sources/ParseSwift/Coding/AnyEncodable.swift 62.84% <90.00%> (+10.54%) ⬆️
...es/ParseSwift/Protocols/ParsePushPayloadable.swift 90.00% <90.00%> (ø)
...s/ParsePushPayload/Apple/ParsePushAppleSound.swift 90.00% <90.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32e269...dcfe0bf. Read the comment docs.

@cbaker6 cbaker6 merged commit 51a44ef into parse-community:main Jun 13, 2022
@cbaker6 cbaker6 deleted the push branch June 13, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant