-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Instagram authentication #372
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
==========================================
+ Coverage 89.00% 89.11% +0.10%
==========================================
Files 137 140 +3
Lines 13402 13546 +144
==========================================
+ Hits 11928 12071 +143
- Misses 1474 1475 +1
Continue to review full report at Codecov.
|
Thanks for your contribution. You will need to install switftlint and make sure your additions doesn’t add any warnings or build errors https://github.com/parse-community/Parse-Swift/blob/main/CONTRIBUTING.md#setting-up-your-local-machine |
Thank you for suggestion. I installed and fixed two warnings. But I have no idea why some tests are failing. They don't look like they are related to what I did. |
I don't see any tests failing after linting. |
It fails on my computer. :( |
Sources/ParseSwift/Authentication/3rd Party/ParseInstagram/ParseInstagram+async.swift
Outdated
Show resolved
Hide resolved
Sources/ParseSwift/Authentication/3rd Party/ParseInstagram/ParseInstagram+async.swift
Outdated
Show resolved
Hide resolved
Note, if you build the SDK using |
Be sure to add an entry to the change log. You can add it at the top under "New Features": https://github.com/parse-community/Parse-Swift/blob/main/CHANGELOG.md |
For auto linting be sure to open |
I did. Please check. Thank you. |
You will need to lint the project before it can pass the tests. Your last few commits haven't addressed a linting issue you had earlier. |
I made a commit which fixed swiftlint warnings earlier. It happened again, I fixed it again. My working environment was fine. I had to run the iOS scheme build. I did not know that. I built it with iOS and it fixed the warning automatically. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM congrats on your first contribution to Parse-Swift!
Thank you so much. :) |
New Pull Request Checklist
Issue Description
This PR is for adding Instagram to 3rd party login providers.
Related issue: #55
Approach
TODOs before merging