Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Instagram authentication #372

Merged
merged 7 commits into from
Jun 20, 2022

Conversation

rocxteady
Copy link
Contributor

@rocxteady rocxteady commented Jun 19, 2022

New Pull Request Checklist

Issue Description

This PR is for adding Instagram to 3rd party login providers.

Related issue: #55

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 19, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #372 (fd4c32d) into main (51a44ef) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   89.00%   89.11%   +0.10%     
==========================================
  Files         137      140       +3     
  Lines       13402    13546     +144     
==========================================
+ Hits        11928    12071     +143     
- Misses       1474     1475       +1     
Impacted Files Coverage Δ
...rd Party/ParseInstagram/ParseInstagram+async.swift 100.00% <100.00%> (ø)
... Party/ParseInstagram/ParseInstagram+combine.swift 100.00% <100.00%> (ø)
...tion/3rd Party/ParseInstagram/ParseInstagram.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 84.95% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a44ef...fd4c32d. Read the comment docs.

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 19, 2022

Thanks for your contribution. You will need to install switftlint and make sure your additions doesn’t add any warnings or build errors https://github.com/parse-community/Parse-Swift/blob/main/CONTRIBUTING.md#setting-up-your-local-machine

@rocxteady
Copy link
Contributor Author

Thanks for your contribution. You will need to install switftlint and make sure your additions doesn’t add any warnings or build errors https://github.com/parse-community/Parse-Swift/blob/main/CONTRIBUTING.md#setting-up-your-local-machine

Thank you for suggestion. I installed and fixed two warnings. But I have no idea why some tests are failing. They don't look like they are related to what I did.

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 19, 2022

They don't look like they are related to what I did.

I don't see any tests failing after linting.

@rocxteady
Copy link
Contributor Author

They don't look like they are related to what I did.

I don't see any tests failing after linting.

It fails on my computer. :(

@cbaker6 cbaker6 changed the title feat: add Instagram login feat: add Instagram authentication Jun 19, 2022
@cbaker6
Copy link
Contributor

cbaker6 commented Jun 19, 2022

Note, if you build the SDK using iOS in Xcode it will automatically fix basic linting issues like spacing, etc.

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 19, 2022

Be sure to add an entry to the change log. You can add it at the top under "New Features": https://github.com/parse-community/Parse-Swift/blob/main/CHANGELOG.md

@cbaker6
Copy link
Contributor

cbaker6 commented Jun 19, 2022

For auto linting be sure to open Parse.xcworkspace and not Package.swift. If you are using Package.swift you will need to run SwiftLint from the command line manually.

@rocxteady
Copy link
Contributor Author

Be sure to add an entry to the change log. You can add it at the top under "New Features": https://github.com/parse-community/Parse-Swift/blob/main/CHANGELOG.md

I did. Please check. Thank you.

@rocxteady rocxteady requested a review from cbaker6 June 19, 2022 16:58
@cbaker6
Copy link
Contributor

cbaker6 commented Jun 19, 2022

You will need to lint the project before it can pass the tests. Your last few commits haven't addressed a linting issue you had earlier.

@rocxteady
Copy link
Contributor Author

You will need to lint the project before it can pass the tests. Your last few commits haven't addressed a linting issue you had earlier.

I made a commit which fixed swiftlint warnings earlier. It happened again, I fixed it again. My working environment was fine. I had to run the iOS scheme build. I did not know that. I built it with iOS and it fixed the warning automatically. Thank you.

Copy link
Contributor

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM congrats on your first contribution to Parse-Swift!

@cbaker6 cbaker6 merged commit 3b3b839 into parse-community:main Jun 20, 2022
@rocxteady
Copy link
Contributor Author

This LGTM congrats on your first contribution to Parse-Swift!

Thank you so much. :)

@rocxteady rocxteady deleted the instagram-login branch June 20, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants