Skip to content

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Oct 4, 2025

New Pull Request Checklist

Issue Description

Same as #2992, but it's missing <SELECT> HTML elements.

Approach

Add <SELECT> HTML elements.

Summary by CodeRabbit

  • Bug Fixes
    • Prevents unintended keyboard shortcuts when focusing or navigating dropdowns.
    • Ensures keyboard interactions in SELECT fields are treated like inputs/textareas, avoiding conflicts.
    • Improves consistency of keyboard navigation across form controls in the Data Browser.
    • Enhances overall UX by reducing accidental actions during dropdown selection.

Copy link

parse-github-assistant bot commented Oct 4, 2025

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@parseplatformorg
Copy link
Contributor

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

coderabbitai bot commented Oct 4, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The keydown handling logic in DataBrowser.react.js was updated to treat SELECT elements like INPUT and TEXTAREA. The guard that prevents global keyboard shortcuts when focus is on form fields now includes SELECT, and the related comment was updated accordingly.

Changes

Cohort / File(s) Summary of Changes
Keyboard event guard update
src/dashboard/Data/Browser/DataBrowser.react.js
Expanded isInputElement check to include SELECT via target.tagName === 'SELECT'; updated comment to mention dropdown navigation and ensure shortcuts don’t trigger while focusing form controls.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant DB as DataBrowser
  participant KH as Keydown Handler

  U->>DB: keydown
  DB->>KH: handleKeydown(event)
  alt Focus on INPUT/TEXTAREA/SELECT
    KH-->>DB: Guard returns (no shortcuts)
    note right of KH: Prevent global shortcut<br/>to allow typing/dropdown navigation
  else Other elements
    KH->>DB: Process global shortcut
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a20f8e5 and ea2594b.

📒 Files selected for processing (1)
  • src/dashboard/Data/Browser/DataBrowser.react.js (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza mtrezza changed the title fix: Filter text field in data browser partly looses focus when hitting enter key to apply filter fix: Filter text field in data browser partly looses focus when selecting in drop-down element by hitting enter key to apply filter Oct 4, 2025
@mtrezza mtrezza merged commit f4c17c7 into parse-community:alpha Oct 4, 2025
10 of 11 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 4, 2025
# [7.6.0-alpha.3](7.6.0-alpha.2...7.6.0-alpha.3) (2025-10-04)

### Bug Fixes

* Filter text field in data browser partly looses focus when selecting in drop-down element by hitting enter key to apply filter ([#2993](#2993)) ([f4c17c7](f4c17c7))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.6.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 4, 2025
@mtrezza mtrezza deleted the fix/select-focus branch October 5, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants