add tests to equalTo with more than one condition and with the same key #477
Conversation
|
@igor-mobapps Thanks for the well-written test cases! Can you update from master so the build can pass? I tried your tests locally and they passed. |
igor-mobapps
force-pushed
the
equalto-with-other-condition
branch
from
84790d6
to
2368d22
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #477 +/- ##
=========================================
Coverage 98.60% 98.60%
Complexity 1062 1062
=========================================
Files 38 38
Lines 3229 3229
=========================================
Hits 3184 3184
Misses 45 45 ☔ View full report in Codecov by Sentry. |
| $query->notEqualTo('fooStack.status', 'baz'); | ||
| $query->equalTo('fooStack.status', 'bar'); | ||
|
|
||
| $this->assertEquals(3, $query->count(true)); |
There was a problem hiding this comment.
Is this the expected results? Should these test fail instead of passing?
There was a problem hiding this comment.
yes, they must fail.
Only tests have been done, once the fix cited in #476 is implemented, they should fail
|
Closing via #510 |
tests for the problem listed here #476