Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve ParseUser::become test #507

Merged
merged 3 commits into from
May 10, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 10, 2023

New Pull Request Checklist

Issue Description

Closes: #478

Approach

Creates User in the cloud and become user on the client side.

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a269f9e) 98.48% compared to head (d0fa843) 98.48%.

❗ Current head d0fa843 differs from pull request most recent head 3be590c. Consider uploading reports for the commit 3be590c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #507   +/-   ##
=========================================
  Coverage     98.48%   98.48%           
  Complexity     1060     1060           
=========================================
  Files            38       38           
  Lines          3225     3225           
=========================================
  Hits           3176     3176           
  Misses           49       49           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza May 10, 2023 17:15
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready for merge?

@dplewis
Copy link
Member Author

dplewis commented May 10, 2023

This is ready to merge

@mtrezza mtrezza merged commit d46107e into parse-community:master May 10, 2023
@dplewis dplewis deleted the test-user-become branch May 12, 2023 18:36
@parseplatformorg
Copy link

🎉 This change has been released in version 2.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version Edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseUser::become not working
3 participants