Fix escaping of shell commands #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
reviewed
Sep 15, 2023
src/HotelCalifornia/Exec.hs
Outdated
| @@ -38,15 +39,18 @@ parseExecArgs = do | |||
| runExecArgs :: ExecArgs -> IO () | |||
| runExecArgs ExecArgs {..} = do | |||
| let script = | |||
| unwords $ NEL.toList execArgsScript | |||
| Escape.escapeMany $ NEL.toList execArgsScript | |||
parsonsmatt
approved these changes
Sep 15, 2023
Before this change, the `hotel` executable wouldn't handle spaces in arguments correctly. A simple example is: ```bash $ hotel exec echo ' a' ``` Before this change that would print: ``` a ``` … and after this change it correctly prints: ``` a ```
|
Fixes #10 |
… for when the user wants to run an arbitrary shell command This also fixes the command-line parser so that you don't need to add `--` before the command to avoid confusing options.
Gabriella439
force-pushed
the
gabriella/fix_escaping
branch
from
63e12cf
to
adcb53e
Compare
|
I added support for a |
parsonsmatt
approved these changes
Sep 15, 2023
|
Note that I can't merge so you'll have to merge this |
|
Released as 0.0.2.0, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the
hotelexecutable wouldn't handle spaces in arguments correctly. A simple example is:Before this change that would print:
… and after this change it correctly prints: