-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle BCs without relocatable device code #1026
Conversation
…rthenon into brryan/particle_bcs_nordc
@brryan: ok, that makes sense. I was just going to try and start seeing what is required to merge this with the mesh constructor refactor PR and the forest PR that is currently in WIP. |
As for the SwarmPacks I'm happy with the discussion and don't plan a detailed review. So just go ahead an merge when everyone is happy. |
…brryan/particle_bcs_nordc and merge in swarmpacks
I verified that this works downstream, including custom reflecting BCs for particles, so I'm enabling auto-merge now. Thanks everyone for reviews |
PR Summary
Particles currently use relocatable device code via inheritance to provide boundary condition functions on a per-particle basis. This PR moves to boundary conditions on particles via kernel launches in a manner analogous to field boundary conditions.
Breaking: completely new particle BCs for downstream codes doing custom implementations.
PR Checklist
Defrag
task)particle_tracers
example to CI