-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Proposals #1126
Community Proposals #1126
Conversation
- Added mechanism to calculate memory size of object in utils. - Make proposal confirmation modal more dynamic and display title and transaction fee of proposal.
…e as well. - requested changes.
- Removed the dead code which used for proposal-transaction-fee calculation at frontend side.
…into proposals Conflicts: modules/clientBinaries/clientBinaries.json
Community Proposals
A build has started for this pull request! |
ebb9c6c +build
|
Weighting based on PART owned is not currently implemented, and so just remove the wording indicating that it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trial by fire 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build has been tested by n > 1 persons, and the code looks decent and does not appear to be doing anything exotic or weird.
Two typos found: In src/app/wallet/proposals/add-proposal/add-proposal.component.html "depands" -> "depends" |
I fixed the typo errors |
No description provided.