Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Proposals #1126

Merged
merged 99 commits into from
Sep 5, 2018
Merged

Community Proposals #1126

merged 99 commits into from
Sep 5, 2018

Conversation

kewde
Copy link
Collaborator

@kewde kewde commented Aug 28, 2018

No description provided.

vikas-cis and others added 30 commits July 3, 2018 16:42
- Added mechanism to calculate memory size of object in utils.
- Make proposal confirmation modal more dynamic and display title and transaction fee of proposal.
@Fiona-Builds
Copy link

A build has started for this pull request!

@Fiona-Builds
Copy link

ebb9c6c +build
Note: the download links expire after 10 days.

fe5bdda622d93945cbc6f7a7a7997ae0ad3b4b82d6d1ae89ce45ba57ba81490a particl-desktop-linux-amd64-PR1126-ebb9c6cb.deb
https://transfer.sh/z9Scu/particl-desktop-linux-amd64-PR1126-ebb9c6cb.deb
http://jxm5d6emw5rknovg.onion/z9Scu/particl-desktop-linux-amd64-PR1126-ebb9c6cb.deb
c5d2078c94c0188c49ab2937b61d1eceede81ff7825161cc48a399c0a1d0e33d particl-desktop-linux-x64-PR1126-ebb9c6cb.zip
https://transfer.sh/dYw89/particl-desktop-linux-x64-PR1126-ebb9c6cb.zip
http://jxm5d6emw5rknovg.onion/dYw89/particl-desktop-linux-x64-PR1126-ebb9c6cb.zip
869f3919f74f8efaca08bf2c586fedc91b06d6fe78a5b8298bd9b95b71c1b61b particl-desktop-mac-PR1126-ebb9c6cb.zip
https://transfer.sh/gYC7r/particl-desktop-mac-PR1126-ebb9c6cb.zip
http://jxm5d6emw5rknovg.onion/gYC7r/particl-desktop-mac-PR1126-ebb9c6cb.zip
62a15c57f5e0e70d5fc70979a1918067771c5149c366e798ad0b1531ad00c97b particl-desktop-win-ia32-PR1126-ebb9c6cb.zip
https://transfer.sh/qPMIP/particl-desktop-win-ia32-PR1126-ebb9c6cb.zip
http://jxm5d6emw5rknovg.onion/qPMIP/particl-desktop-win-ia32-PR1126-ebb9c6cb.zip
b9afa7e855a4a6d0b81177b881540b5ec221336544888ff4e95a726d66aa87d8 particl-desktop-win-x64-PR1126-ebb9c6cb.zip
https://transfer.sh/J7XJZ/particl-desktop-win-x64-PR1126-ebb9c6cb.zip
http://jxm5d6emw5rknovg.onion/J7XJZ/particl-desktop-win-x64-PR1126-ebb9c6cb.zip

kewde and others added 3 commits September 3, 2018 14:38
Weighting based on PART owned is not currently implemented, and so just remove the wording indicating that it is.
Copy link
Collaborator Author

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trial by fire 👍

Copy link
Collaborator

@zaSmilingIdiot zaSmilingIdiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build has been tested by n > 1 persons, and the code looks decent and does not appear to be doing anything exotic or weird.

@zaSmilingIdiot zaSmilingIdiot merged commit 3780fd8 into market Sep 5, 2018
@cryptoguard
Copy link

Two typos found:

In src/app/wallet/proposals/add-proposal/add-proposal.component.html

"depands" -> "depends"

@cis-shubham-t
Copy link
Contributor

I fixed the typo errors
here is the PR: #1138

@kewde kewde deleted the proposals branch September 24, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants