-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal layout unification #758
Conversation
Tried to disable animations (https://material.angular.io/guide/getting-started#step-2-animations), after that I can't reproduce the issue. Can @vikas-cis and @anandsinghparihar confirm? |
@AllienWorks it seems the issue is not appearing but the modal looks ugly to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllienWorks its working fine in mac & Linux now, you removed all animation from app its not look good.
So after reading a lot of different issues in angular/material and related, I found a lot of other devs (1, 2, 3) having the same issues as we have (moved elements or their parts). Looks like it's a problem with Electron and not Angular Material, apparently after updating to latest Electron (1.8.2) beta everything works as expected (source). Can we try that? At least in some testing branch (like this one)? Would be great to pin point the problem, so at least we know where it originates. We could focus on other issues and when Electron 1.8.2 is stable and out, simple update will hopefully do. |
This reverts commit cb92208.
I've unified the modals look and code. The situation Then we have the "big" modals (e.g. Create wallet, Encrypt wallet, Cold staking), which are built with the
What needs to be done I'm not quite sure if it's possible, but it should be. Can someone look into it? I would start by adapting the |
I'd like to focus on moving the "big modals" out as much as possible and then fix the ones that are left.. |
@kewde absolutely. Let me know, we'll work it out. |
@vikas-cis @anandsinghparihar can you test again, if the "jumping content" bug is still present? Thanks! |
@AllienWorks it seems when I try to open cold staking modal from widget 4-5 times and then I try 6th time then it stuck not sure why ? |
@AllienWorks check boxes for coldstaking widget and unlock modal are still moving as shared you via screenshare Thanks |
@vikas-cis the screen you shared is the result of all I wrote above. We need to rework the modals. Already on that with @kewde. |
Edit by @AllienWorks: (fixed) |
Are we still going to need this? |
@rynomster yes, absolutely. We need to rework the modals altogether. Current setup isn't done properly (speaking about layout). |
Already solved in #1025 |
WIP PR containing experiments and debug for the modals' layout.
Closes #694, #753