AT parser and gsm0710 muxer custom log category support #2267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that we have ESP32 support on Tracker, it's impossible to differentiate between NCP client / gsm0710 muxer logs that come from the cellular modem and ESP32.
Solution
Add instance-local custom log categories support for AT parser and gsm0710muxer.
This PR also fixes a bug in
ChannelStream
inwaitEvent()
timeout handling and makes sure that we have a single implementation of the gsm0710muxer (by having a common Stream base class that supporteventGroup()
method).Steps to Test
Run the test app, watch logs. It should be easy to differentiate NCP/muxer logs that come from the modem and from ESP32.
Example App
Logs
References
Completeness