-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to node@16 and npm@8 #142
Update to node@16 and npm@8 #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@deleonn i see this in the CI logs for the test step:
any ideas? |
e434e6a
to
46d10cc
Compare
2cbe86c
to
9f05407
Compare
9f05407
to
51337e7
Compare
.circleci/config.yml
Outdated
- image: mongo:4.2 | ||
auth: | ||
username: $DOCKERHUB_USERNAME | ||
password: $DOCKERHUB_PASSWORD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can go away i think
.circleci/config.yml
Outdated
- run: | ||
name: Run tests with browser | ||
command: npm run test:browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i created a record in 1Password w/ the required API credentials. Pull those into CircleCI (make sure they are hidden from public view as this is a public repo) and wire up the node-side tests.
i don't think you need to run the browser tests across multiple versions of node since the runtime in that case is the browser itself and it will always be the same (at least as it is currently configured).
ideally, we'd run the node-side tests across multiple versions of node but the brower-side tests in a single version (presumably node@16
)
Description
Makes the required changes so the library works with
node@16x
andnpm@8.x
. This PR also migrates from TravisCI to CircleCI and introduces the same automatic publishing flow asmongoose-models
.How to Test
feature/sc-102555/update-particle-api-js-to-node-js-v16-and
v16.x
and npm to version tov8.x
. Usenvm use 16
or equivalent.node -v && npm -v
npm i
npm run test
Outcome
All tests should pass. npm i should run without issues.
Related / Discussions
Completeness
main
)