-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.getEventStream method compatible with new product event stream endpoints #28
Conversation
@@ -1,4 +1,5 @@ | |||
{ | |||
"root": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why lint only the current directory? npm run lint
passes for me without this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents eslint
from searching above this directory for configuration. It doesn't actually limit it to the current directory, but anything below the current directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Thanks. So we leave this in then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@brycekahle Should we only update the |
Yeah, probably. Also not updating docs until a release is best. |
Agreed Bryce. I noticed that updating the docs changes all the hashes so doing it not too frequently is best. The actual change is good. @jme783, I'll squash the commits and merge. |
eff21c2
to
991447b
Compare
Sorry about running the build. Didn't realize that this was done automatically |
I pulled the rug under Travis' feet by deleting the branch before the checks finished... |
Support the following new routes (all have tests):