Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.getEventStream method compatible with new product event stream endpoints #28

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

jme783
Copy link
Contributor

@jme783 jme783 commented Jun 8, 2016

Support the following new routes (all have tests):

/v1/products/:productIdOrSlug/events
/v1/products/:productIdOrSlug/events/:event_name
/v1/products/:productIdOrSlug/devices/:orgDeviceId/events
/v1/products/:productIdOrSlug/devices/:orgDeviceId/events/:event_name

@@ -1,4 +1,5 @@
{
"root": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why lint only the current directory? npm run lint passes for me without this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents eslint from searching above this directory for configuration. It doesn't actually limit it to the current directory, but anything below the current directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks. So we leave this in then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@monkbroc
Copy link
Member

monkbroc commented Jun 8, 2016

@brycekahle Should we only update the dist folder right before a release to avoid merge conflicts in PRs?

@brycekahle
Copy link
Contributor

Yeah, probably. Also not updating docs until a release is best.

@monkbroc
Copy link
Member

monkbroc commented Jun 8, 2016

Agreed Bryce. I noticed that updating the docs changes all the hashes so doing it not too frequently is best.

The actual change is good. @jme783, I'll squash the commits and merge.

@monkbroc monkbroc merged commit 30d462f into master Jun 8, 2016
@monkbroc monkbroc deleted the feature/new-pricing branch June 8, 2016 20:06
@jme783
Copy link
Contributor Author

jme783 commented Jun 8, 2016

Sorry about running the build. Didn't realize that this was done automatically

@monkbroc
Copy link
Member

monkbroc commented Jun 8, 2016

I pulled the rug under Travis' feet by deleting the branch before the checks finished...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants