Feature/products device get var #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers of lib/api.js
…variable from a product device
wraithan
reviewed
Feb 11, 2020
| getValue({ time, product, params: { device, variableName } }){ | ||
| if (product){ | ||
| if (!device){ | ||
| throw usageError( |
There was a problem hiding this comment.
😍 changing out the throwing of generic errors for named ones
wraithan
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Looks like a great changeset to me, cli/variable.js reads a lot better now with the flow changes and named errors.
Reading the e2e test changes made me realize I could/should use the CLI's end to end tests against my locally running stack as an additional layer of validation, I'll let you know how that goes when I try it later today.
monkbroc
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for optional
--product <id>flag to theparticle variable getcommand to fetch a variable from a product device (ch)How to Test
Note: requires you to have a Particle product with one or more devices
Run
particle variable get --helpand explore the command and options.Completeness