Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/sc-126221/upload-artifacts-to-s3-from-ci #725

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Apr 8, 2024

Description

This PR will:

  • Generate CLIInstaller for windows (offline installation)
  • Add the ability to publish new binaries to an s3 bucket
  • Generate (When pushing a new version) a manifest.json for the current version being published and also (in case is not a pre-release) update the current "latest" manifest.json

Note

All tests and publish jobs were disabled (commented) in the yaml.
This should be restored in next PR's

How to Test

  • Visit the latest circleCI execution
  • Check a circleCI execution with a tag test-3.23.3
  • Check manifest.json
  • Attempt to download the urls for each binary in the manifest

Outcome

  • In CircleCI artifacts for that execution you will see all binaries and the cli Windows Installer
  • The tag will have a publish step
  • You will be able to see the manifest and download the files by using the urls into the document

Related Issues / Discussions

Epic: https://app.shortcut.com/particle/epic/126209/cli-installer-v2
Story details:

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero changed the title Feature/sc 126221/upload artifacts to s3 from ci feature/sc-126221/upload-artifacts-to-s3-from-ci Apr 11, 2024
@hugomontero hugomontero marked this pull request as ready for review April 11, 2024 14:15
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

installer/windows/GetWindowsVersion.nsh Outdated Show resolved Hide resolved
installer/windows/ParticleCLISetup.nsi Outdated Show resolved Hide resolved
installer/windows/ParticleCLISetup.nsi Outdated Show resolved Hide resolved
installer/windows/ParticleCLISetup.nsi Outdated Show resolved Hide resolved
@@ -0,0 +1,26 @@
# Particle CLI Installer

Downloads and installs the latest CLI wrapper from binaries.particle.io,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that this readme needs to be updated. Doesn't need to be in this PR

scripts/generate-manifest.js Outdated Show resolved Hide resolved
src/app/cli.js Outdated Show resolved Hide resolved
@monkbroc monkbroc self-assigned this Apr 11, 2024
@monkbroc monkbroc removed their assignment Apr 11, 2024
@hugomontero hugomontero force-pushed the feature/sc-126221/upload-artifacts-to-s3-from-ci branch from eb19670 to 4d4e528 Compare April 11, 2024 18:34
@hugomontero hugomontero merged commit 088b629 into feature/cli-installer-v2 Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants