-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/sc-126221/upload-artifacts-to-s3-from-ci #725
Merged
hugomontero
merged 26 commits into
feature/cli-installer-v2
from
feature/sc-126221/upload-artifacts-to-s3-from-ci
Apr 11, 2024
Merged
feature/sc-126221/upload-artifacts-to-s3-from-ci #725
hugomontero
merged 26 commits into
feature/cli-installer-v2
from
feature/sc-126221/upload-artifacts-to-s3-from-ci
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
changed the title
Feature/sc 126221/upload artifacts to s3 from ci
feature/sc-126221/upload-artifacts-to-s3-from-ci
Apr 11, 2024
monkbroc
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@@ -0,0 +1,26 @@ | |||
# Particle CLI Installer | |||
|
|||
Downloads and installs the latest CLI wrapper from binaries.particle.io, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder that this readme needs to be updated. Doesn't need to be in this PR
hugomontero
force-pushed
the
feature/sc-126221/upload-artifacts-to-s3-from-ci
branch
from
April 11, 2024 18:34
eb19670
to
4d4e528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will:
Note
All tests and publish jobs were disabled (commented) in the yaml.
This should be restored in next PR's
How to Test
test-3.23.3
Outcome
publish
stepRelated Issues / Discussions
Epic: https://app.shortcut.com/particle/epic/126209/cli-installer-v2
Story details:
Completeness