Use @particle/device-os-protobuf instead of the proto submodule #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeramis
force-pushed
the
feature/remove-proto-dir
branch
from
1f7bb05
to
4749395
Compare
monkbroc
approved these changes
Jan 29, 2024
package.json
Outdated
| "build:web": "webpack-cli", | ||
| "docs": "documentation build src/** -g -f md -o docs/reference.md", | ||
| "clean": "rm -rf ./dist ./lib", | ||
| "reinstall": "npm run clean && rm -rf ./node_modules && npm i" | ||
| "reinstall": "npm run clean && rm -rf ./node_modules && rm -rf proto/ && npm i" |
There was a problem hiding this comment.
Let's ask our internal users to clean up proto manually since it involves removing some entries from .git as well and it's a one-off thing.
| @@ -2,7 +2,7 @@ const { Request } = require('./request'); | |||
| const { fromProtobufEnum } = require('./protobuf-util'); | |||
| const { convertBufferToMacAddress } = require('./address-util.js'); | |||
| const { globalOptions } = require('./config'); | |||
| const proto = require('./protocol'); | |||
| const { definitions: proto } = require('@particle/device-os-protobuf'); | |||
There was a problem hiding this comment.
I prefer this form vs the one you have in device.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Particle USB library relies on the
device-os-protobuflibrary, which is currently installed both as a direct dependency in the node_modules folder and included as a submodule calledproto. This pull request streamlines the dependency management by removing the submodule and exclusively utilizing the installed dependency within the node_modules folder.