Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkding 1.0.5 Helm chart broke my deployment #298

Closed
kalmarz opened this issue May 22, 2023 · 5 comments · Fixed by #300
Closed

linkding 1.0.5 Helm chart broke my deployment #298

kalmarz opened this issue May 22, 2023 · 5 comments · Fixed by #300
Assignees
Labels
bug Something isn't working todo This will be worked on

Comments

@kalmarz
Copy link

kalmarz commented May 22, 2023

I tried to upgrade from chart version 0.3.1 to the latest 1.0.5 (at the time of writing) and it failed with the error: reconciliation failed: Helm upgrade failed: cannot patch "linkding" with kind Deployment: Deployment.apps "linkding" is invalid: spec.template.spec.containers[0].volumeMounts[0].name: Not found: "storage-volume"

I have a pre-baked PV and PVC that I refer to and they've worked quite well so far.

---
kind: PersistentVolume
apiVersion: v1
metadata:
  name: storage-volume
spec:
  capacity:
    storage: 10Gi
  accessModes:
  - ReadWriteOnce
  persistentVolumeReclaimPolicy: Retain
  storageClassName: local-path
  local:
    path: /home/....
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: storage-volume
  namespace: linkding
spec:
  accessModes:
  - ReadWriteOnce
  storageClassName: local-path
  resources:
    storage: 10Gi
---
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: HelmRepository
metadata:
  name: pascaliske
  namespace: linkding
spec:
  interval: 60m
  url: https://charts.pascaliske.dev
---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: linkding
  namespace: linkding
spec:
  interval: 30s
  chart:
    spec:
      chart: linkding
      version: "0.3.1" # <- I only changed this line to 1.0.5
      sourceRef:
        kind: HelmRepository
        name: pascaliske
        namespace: linkding
      interval: 60m
  values:
    persistentVolumeClaim:
      create: false
      existingPersistentVolumeClaim: storage-volume
---

The cluster is managed with FluxCD, hence the HelmRepository and HelmRelease objects. What I saw among the k8s events was the Helm release tried to provision another volume, named linkding-storage and disregarded my pre-made PV and PVC although they were there and named exactly as the release required. Any pointer would be greatly appreciated.

@kalmarz kalmarz added the bug Something isn't working label May 22, 2023
@pascaliske
Copy link
Owner

Hi @kalmarz,

Thanks for reporting this! You're right, there are two bugs in the Helm Chart. 🙈
I will try to fix those as soon as I have some free time and will let you know here...

BR, Pascal

@pascaliske
Copy link
Owner

Please see the latest release linkding-1.0.6 which hopefully fixes this bug. 🙂

@kalmarz
Copy link
Author

kalmarz commented May 23, 2023

It did. Thank you for the prompt update.

@pascaliske
Copy link
Owner

@all-contributors please add @kalmarz for bug 👌🏻

@allcontributors
Copy link
Contributor

@pascaliske

I've put up a pull request to add @kalmarz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working todo This will be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants