lz_analyze fixes #135
Merged
lz_analyze fixes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonsqueeze
force-pushed
the
lz_analyze_fix
branch
4 times, most recently
from
70f661f
to
19c0928
Compare
lemonsqueeze
force-pushed
the
lz_analyze_fix
branch
2 times, most recently
from
d797d9d
to
a32a309
Compare
updated doc
renamed spawn_worker() -> worker_thread()
spawn_thread_manager() -> thread_manager()
spawn_logger() -> logger_thread()
which is only valid if last move exists but half of the time we forget to check ...
can genmove b, genmove b now works for lz-genmove_analyze too
Sabaki uses this handle switching color to play
final newline early on confuses sabaki, lz-analyze should just output "= \n" at first, and send final newline when next command comes in. leela-zero does this too need to flush stream too otherwise hanging issue when tree overflows
gtp.c keeps track if we are in analyze mode or genmove mode. Reset engine when switching from analyze mode <-> genmove move only. This way we don't lose analyze state when toggling analyze on and off. We don't want analyze tree to affect next genmove either.
if playing by time settings and we're asked to analyze after a play command timer will be running the whole time since play command starts the timer. by the time next genmove comes in we're out of time: genmove b play w d4 lz-analyze b 50 <wait> genmove b so reset timer when switching back to genmove mode
|
Getting ready, should be much better now:
|
lemonsqueeze
force-pushed
the
lz_analyze_fix
branch
from
a32a309
to
19b7837
Compare
uct:
pondering + analyzing: just resume pondering with analyze-style output
and resume normal pondering when told to stop analyzing.
finish expanding dcnn nodes if we were interrupted.
gtp:
normal: reset engine when switching from analyze mode -> genmove mode
analyze tree shouldn't affect next genmove.
pondering: don't reset !
engine handles switching from pondering <-> pondering + analyzing */
until now uct_pondering_start() always garbage collected the tree when pondering if needed.
need a way to turn it off: don't want garbage collection to happen when we resume analyzing
otherwise we lose much of the search tree.
if you want tree garbage collection:
u->pondering_want_gc = true
uct_pondering_start()
otherwise just:
uct_pondering_start()
lemonsqueeze
force-pushed
the
lz_analyze_fix
branch
from
19b7837
to
e6cb11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #134 and cleanup / sanity checks:
lz-analyze <color> <freq>syntax for Sabaki