Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to using absolute imports (for python3) #32

Merged
merged 1 commit into from
Aug 20, 2018
Merged

move to using absolute imports (for python3) #32

merged 1 commit into from
Aug 20, 2018

Conversation

AlJohri
Copy link
Contributor

@AlJohri AlJohri commented Aug 14, 2018

  • move benchmark.py outside of the paradox folder (it would require running as python -m paradox.benchmark if you wanted to keep it in the folder)
  • use computed relative paths GLOVE_FOLDER and CORPUS_FOLDER starting from the root paradox folder (for being able to import paradox in another project where paths relative to CWD don't work)

ref on need for abs imports: https://chrisyeh96.github.io/2017/08/08/definitive-guide-python-imports.html#absolute-vs-relative-import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants