Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per architecture kubectl download #74

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Per architecture kubectl download #74

merged 1 commit into from
Jan 9, 2024

Conversation

ook
Copy link
Contributor

@ook ook commented Jan 9, 2024

…t kubectl version according cpu architecture

Fix: #73

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

@dlen
Copy link
Member

dlen commented Jan 9, 2024

Hello! Thanks for your contribution! This is a duplicate of #44 which was closed as we thought it would be enough by changing the download URL in the values.yaml. However it looks like there is some traction about automatic detection of cpu arch. In that case I would reopen #44 unless there is something missing in that implementation

@ook
Copy link
Contributor Author

ook commented Jan 9, 2024

Hello @dlen ! Thank you for this quick response. #44 can't work since uname -m won't map to dl.k8s.io path (they publish on pathes amd64 or arm64 while uname -m return x86_64 on mac (intel) and aarch64 on raspberry pi boards. My PR do the needed mapping.

I understand the env KUBECTL_DOWNLOAD_CMD is enough to bypass the issue, but it lacks some documentation: the README.md is not explicit enough (from my point of view) to guide the user to this value, and there's no "Troubleshooting" section where we could explain this problem. Since Passbolt advertises heavily the usage of raspberry pi, I'm pretty sure my PR could save some issues in this repository ^^

@dlen
Copy link
Member

dlen commented Jan 9, 2024

Alright sounds good to me. We'll continue with your PR.

Thanks a lot!

@dlen dlen changed the title https://github.com/passbolt/charts-passbolt/issues/73 Download correc… Per architecture kubectl download Jan 9, 2024
@dlen dlen merged commit f5c1012 into passbolt:main Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job-create-jwt -> kubectl: cannot execute binary file: Exec format error
3 participants