Merge branch 'feature/PB-28679-fix-password-expiry-settings-entity' i…

…nto 'feature/PB-28018_EPIC---Password-expiry' PB-28679: fix createFromDefault method for the CE version of the PasswordExpirySettingsEntity See merge request passbolt/passbolt-styleguide!1425
passbolt · Dec 1, 2023 · 682fe95 · 682fe95
2 parents 02bd24b + 55c285d
commit 682fe95
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "passbolt-styleguide",
-  "version": "4.5.0-alpha.1",
+  "version": "4.5.0-alpha.2",
   "license": "AGPL-3.0",
   "copyright": "Copyright 2023 Passbolt SA",
   "description": "Passbolt styleguide contains common styling assets used by the different sites, plugin, etc.",

diff --git a/src/shared/models/entity/passwordExpiry/passwordExpirySettingsEntity.js b/src/shared/models/entity/passwordExpiry/passwordExpirySettingsEntity.js
@@ -111,10 +111,6 @@ class PasswordExpirySettingsEntity extends Entity {
     };
 
     const dto = {...defaultData, ...data};
-    for (const key in dto) {
-      dto[key] ??= defaultData[key];
-    }
-
     return new PasswordExpirySettingsEntity(dto);
   }
 }