Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for valid sitemap.xml #6

Closed
BarryBotha opened this issue Oct 5, 2016 · 3 comments
Closed

check for valid sitemap.xml #6

BarryBotha opened this issue Oct 5, 2016 · 3 comments
Assignees
@Johanndutoit
Labels
enhancement

Comments

@BarryBotha
Copy link
Contributor

Although we do not believe in the necessity of a sitemap.xml file we do believe that if you have one it should be valid. If /sitemap.xml returns 200 we should parse it to make sure its valid.

Read more: http://www.sitemaps.org/protocol.html
@Johanndutoit Johanndutoit self-assigned this Oct 5, 2016
@Johanndutoit
Copy link
Contributor

Ooooh that is interesting yes, would save a few servers some processing too if they are rendering the entire page instead of either a 404 or XML. PR incoming 👍

@Johanndutoit
Copy link
Contributor

Johanndutoit commented Oct 6, 2016 •
edited
Loading

Storm-is-a-brewing - #10, feedback much appreciated :)

@Johanndutoit
Copy link
Contributor

Merged and going live after some testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Johanndutoit Johanndutoit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Johanndutoit @BarryBotha