Sitemap Check / Validation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut for now this covers the basic structure
|
See node v0.12 requires some work as |
…usted end of the year anyway
|
Upped the version required to v0.12, it's not worth supporting v0.12 as it's dropping of end of the year anyway |
BarryBotha
reviewed
Oct 10, 2016
|
|
||
| ]; | ||
|
|
||
| // get the robots from site |
There was a problem hiding this comment.
Referencing robots and not sitemap
| if(err) { | ||
|
|
||
| // output to log | ||
| payload.error('Problem checking the robots txt', err); |
There was a problem hiding this comment.
Referencing robots and not sitemap
| // add the occurence | ||
| payload.addRule(rulePrologMeta, { | ||
|
|
||
| message: 'Sitemap prolog have $ as a closing tag', |
| // add the rule | ||
| payload.addRule(ruleSchemaMeta, { | ||
|
|
||
| message: 'The root node of the site ($) should contain only $ nodes', |
| describe('sitemap', function() { | ||
|
|
||
| // add the test for the robot | ||
| it('Should not return a error if the /sitemap.xml url returned anything else than a 200', function(done) { |
|
|
||
| // check for a error | ||
| if(err) | ||
| assert.fail('Was not expecting a error'); |
|
|
||
| // check if we found it | ||
| if(!rule) | ||
| assert.fail('Was expecting a rule to return'); |
| }); | ||
|
|
||
| // add the test for the robot | ||
| it('Should not return a error if the sitemap returned as application/xml', function(done) { |
|
|
||
| // check for a error | ||
| if(err) | ||
| assert.fail('Was not expecting a error'); |
| }); | ||
|
|
||
| // add the test for the robot | ||
| it('Should not return a error if the sitemap returned as text/xml', function(done) { |
There was a problem hiding this comment.
and so for all of them...
|
@BarryBotha ^ grammar fixes as requested (oops) |
|
Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a check for the sitemap as well as validation if present. We're not too worried about sitemaps but if one is defined it should be in the right format, and if none are present the url /sitemap.xml should not return a catchall page that renders the homepage or something.
Consider this the first version, it currently checks:
text/xmlorapplication/textwhich should stop any HTML pages throughGoing to see about adding actual value validation for each of the properties as they all have their own specs for how the data should be presented