Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to CONTRIBUTING-TR.md #193

Closed
sadikkuzu opened this issue Jan 7, 2022 · 3 comments
Closed

Suggestions to CONTRIBUTING-TR.md #193

sadikkuzu opened this issue Jan 7, 2022 · 3 comments

Comments

@sadikkuzu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Update git remote address and update broken link.

Describe the solution you'd like

Change upstream git remote address in CONTRIBUTING-TR.md
hoodiehq -> passwall
as done in CONTRIBUTING.md

Change "şuradan" link of
"Açık kaynak projeye nasıl katkıda bulunulabileceğini anlatan daha detaylı bir dokümana şuradan ulaşabilirsiniz."

https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
->
https://app.egghead.io/playlists/how-to-contribute-to-an-open-source-project-on-github

@yakuter
Copy link
Collaborator

yakuter commented Jan 7, 2022

Thank you @sadikkuzu nice catch. Would you like to do it and send PR or I can handle it?

@sadikkuzu
Copy link
Contributor Author

My pleasure @yakuter 🙏🏼

Sure, I can send a PR.

@yakuter
Copy link
Collaborator

yakuter commented Jan 7, 2022

Great thank you.👍

@yakuter yakuter closed this as completed in 1a2130d Jan 7, 2022
yakuter added a commit that referenced this issue Aug 22, 2022
* removed api check on signup

* added recaptcha to signup

* fixed unrelated email issue (#151)

* go-fmt for auth.go

* change goroutine email

* fix subscription status

* update recaptcha

* fix signin email conflict

* little changes

* disabled Recaptcha

* updated Readme

* update go mod

* youtube link (#158)

* added type conv. check

* added RespondWithEncJSON

* changed Decrypt payload

* added helper test

* refactor logins

* update test data

* added test suite

* add env dev to emails

* Refactoring Some Functions (#160)

* refactor bankaccount functions

* refactor creditcard functions

* refactor server functions

* refactor note functions

* deleted recaptcha func (#159)

* TODO about CreateUser fixed (#161)

* create user actions moved to the service layer

* some user tests introduced (#164)

* some user tests introduced
Signed-off-by: Ahmet Turkmen <f.ahmet.turkmen@icloud.com>

* UUID enhancement (#168)

* update mw
* fixed token invalidation

* added validator to app/user (#169)

* fix: add email template

* fix: auth confirmation code

* fix: update subcription process

* fix: add redirect after email confirm

* fix: updare subscription

* change login logic

* update docker compose

* Update error message (#171)

* delete a user without logging in (#173)

* fix refresh token with userUUID

* feat: add change master password feature

* update

* ADD db ssl mode issue #177 (#178)

* add cli and fix db usessl docker

* update docker file with passwall-cli

* add create subscription to cli

* add config.yml to gitignore

* Update jwt package (#179)

* implemented new logger package

* update db gorm package and seperate update and create

* change JWT storage to cookie

* add cookie bugs

* add signout and refactor

* minor fixes

* add both bearer and cookie support

* fix minor bug

* add wait for postgres to docker-compose

* Readme (#182)

* Add comment lines to repository interface (#183)

* Refactored Any function  (#185)

* Refactored Any function

* Renamed function name

* Add argument to function (#186)

* Refactored Any function

* Renamed function name

* Add return argument to function

* minor fixes

* Add auto ssl with lets encrypt (#189)

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>

* update docker compose files

* remove query parameter args

* update readme for docker compose

* Export Feature (#190)

* Add export endpoint for data exporting

* Add export handlers

* Update export handler

* fix export errors

* Add return error if decryption fails (#191)

* Fix typo and broken link (#194)

Closes #193 
* fix upstream git remote address
* fix broken link of a document

* upgrade go version to 1.17 (#195)

Signed-off-by: mrtrkmn <f.ahmet.turkmnen@icloud.com>

Co-authored-by: mrtrkmn <f.ahmet.turkmnen@icloud.com>

* add Makefile

* update go.mod

* improve startup logging

* refactor: refactor export function and minor improvements

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Co-authored-by: Emre Dipi <mail@emredipi.com>
Co-authored-by: Recep Alaca <recep@users.noreply.github.com>
Co-authored-by: Fatih Sezgin <36262782+fatihsezgin@users.noreply.github.com>
Co-authored-by: Ahmet Türkmen <f.ahmet.turkmen@icloud.com>
Co-authored-by: Mehmet Güngören <mehmet_gungoren@hotmail.com>
Co-authored-by: Yakut Özcan <yakutozcan@gmail.com>
Co-authored-by: Ahmet Can Çiçek <ahmetcancicek@hotmail.com>
Co-authored-by: Ahmet Can Çiçek <ahmetcan@ahmetcancicek.com>
Co-authored-by: Kaan Karakaya <yusufkaan142@gmail.com>
Co-authored-by: SADIK KUZU <sadikkuzu@hotmail.com>
Co-authored-by: mrtrkmn <f.ahmet.turkmnen@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants