Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model.simulate doesn't respect tmin #70

Closed
mbakker7 opened this issue Jun 12, 2018 · 3 comments
Closed

Model.simulate doesn't respect tmin #70

mbakker7 opened this issue Jun 12, 2018 · 3 comments
Labels
bug Indicates an unintended behavior or coding error

Comments

@mbakker7
Copy link
Collaborator

When supplying tmin to Model.simulate, it returns values before tmin for the entire warmup period.
@mbakker7 mbakker7 added the bug Indicates an unintended behavior or coding error label Jun 12, 2018
@raoulcollenteur
Copy link
Member

Yes, the tmin should be applied all the way in the end of the simulate, as the warmup period is important for the simulated values. I will look at this later this week.

raoulcollenteur added a commit that referenced this issue Jun 13, 2018
@raoulcollenteur
Restuctured code in Model class
00a236f 
Restructured a large part of the the Model class and other files to be more readable and easier to understand what is going in. This involved removing redundant code (such as removing get_oseries_calib which could be combined with the observations method), renaming variables to be more consistent and making some names easier to understand. Basically, nothing changed (except internally), except that I also addressed issue #70 , which is now solved.

- updated get_sim_index
- removed get_oseries_calib
- simulation is called sim everywhere (renamed h => sim in simulate), residuals are res, noise is noise. odelt is odelt. stressmodels as sm. Still need to do oseries and oseries_calib...
- ml.simulate respects tmin. extra keyword is added to obtain the simulation in the warmup period.
@raoulcollenteur
Copy link
Member

I fixed this in commit 00a236f .

It is still possible to obtain the simulation the warmup period by using the return_warmup=True keyword:

ml.simulate(return_warmup=True)

But by default it is False.

@pastas
Copy link
Collaborator

pastas commented Jun 13, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbakker7 @raoulcollenteur