-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch onno #127
Branch onno #127
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #127 +/- ##
==========================================
- Coverage 66.05% 65.54% -0.51%
==========================================
Files 31 31
Lines 3246 3274 +28
==========================================
+ Hits 2144 2146 +2
- Misses 1102 1128 +26
Continue to review full report at Codecov.
|
Let's do this in a separate PR
Hi Onno, thanks for your PR with some nice �additions! Couple of small things to do before we can merge: Add_models method
add_recharge method
All methods
Final note on the other changes:
Let's do this in a separate PR request. |
Use add_model and reduce code lines.
I changed a couple of things and did some commits to the PR. You'll have to pull first. Can you check if it all still works? What do you think about using model names instead of using model objects? |
Thanks for checking and the changes you made.
|
I changed the 'add_recharge' method in project.py and added 'solve_models' and 'add_models' so you can apply these methods to all models at once instead of one model at the time. Changes:
Besides changed default parameter bounds of pmin and pmax for rfunc One to -100 and +100 when up is None.