Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with RedisCache.prototype.keys ignoring the pattern parameter #24

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fixed issue with RedisCache.prototype.keys ignoring the pattern parameter #24

merged 1 commit into from
Mar 21, 2019

Conversation

nucleoid
Copy link
Contributor

The RedisCache keys prototype function was completely ignoring the pattern parameter other than setting a default value for it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.266% when pulling 34a73d6 on mediasuitenz:fix_redis_cache_keys_pattern into 3e61a99 on pasupulaphani:master.

@pasupulaphani pasupulaphani merged commit e678bbd into pasupulaphani:master Mar 21, 2019
@nucleoid
Copy link
Contributor Author

Coverage Status

Coverage remained the same at 91.266% when pulling 34a73d6 on mediasuitenz:fix_redis_cache_keys_pattern into 3e61a99 on pasupulaphani:master.

FYI, coverage remained the same because the original unit test for this functionality was flawed.

@pasupulaphani
Copy link
Owner

Yeah. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nucleoid @coveralls @pasupulaphani