add new terms Diandrous and monandrous #350
Conversation
|
I would like to add to this PR by including terms for diandrous and monandrous. Even though they were requested in PCO (see PopulationAndCommunityOntology/pco#69) because they are population qualities, I think they should be created in PATO then imported into PCO. |
|
I will check out this branch and make the changes, assuming I can get the github method right. |
|
@ramonawalls if you have any issues, I'm around right now and can (try to) help |
|
@diatomsRcool, I cannot add you as a reviewer, because you are not a member of this repo, but please do review this PR. |
|
Looks good to me |
|
@nicolevasilevsky can you fix the conflicts? Also this PR seems to have more changes than is advertised in the title |
|
@nicolevasilevsky please review carefully the isas before merging, because of all the hack-slashing i needed to do |
|
will do, thanks for your help @matentzn |
| created_by: http://orcid.org/0000-0001-5208-3432 | ||
|
|
||
| [Term] | ||
| id: PATO:0040052 |
There was a problem hiding this comment.
when I open the OWL file, the ID for this term is PATO_0070037
There was a problem hiding this comment.
I dont know, something seems really wrong here.. Maybe lets do this together in our face2face on Thursday. The only thing that can be wrong is the subclassOf axioms - the terms should be correct.
| created_by: https://orcid.org/0000-0001-8815-0078 | ||
|
|
||
| [Term] | ||
| id: PATO:0040053 |
There was a problem hiding this comment.
the ID for this term is PATO_0070038 in the OWL file
There was a problem hiding this comment.
the pato-edit.owl file
There was a problem hiding this comment.
Oh, I guess it is pato-edit.obo, that is what I meant, obo, not owl
| created_by: https://orcid.org/0000-0001-8815-0078 | ||
|
|
||
| [Term] | ||
| id: PATO:0040054 |
There was a problem hiding this comment.
in the OWL file, this ID is PATO_0070036
and the parent is 'neurogliaform morphology' (which seems wrong)
|
@matentzn there seem to be lots of issues with this - I think it's probably easier to just close this and start over. I can do so, once you give me the go ahead. |
|
Lets discuss at next meeting. |
|
talked to @matentzn - I will redo this |
|
recreated this PR, closing this. |
closes #257