Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for uSync #175

Draft
wants to merge 3 commits into
base: dev/Umbraco11
Choose a base branch
from
Draft

Conversation

krebil
Copy link

@krebil krebil commented Mar 16, 2023

The initial draft for uSync implementation.

  • Sync meta field- / SEO field values

  • Support language variants

  • Sync SEO settings

For now both handlers are under settings in the uSync dashboard.. not sure why.
Events could be added in the respective services to trigger uSync if it's configured to automatically export on updates. But I think this is out of scope for now.

Data in the database doesn't change when disabling SEO settings on a document-type. So not sure how to check for that type of change.

@krebil krebil marked this pull request as draft March 16, 2023 21:22
@patrickdemooij9
Copy link
Owner

Hi @krebil,
Sorry for coming back to this so late. But the work you have done here is amazing! I just gave it a run and it seems to work quite well. I also managed to figure out how to move everything to their own group, so I have commited that.

I did spot an issue where changes aren't tracked correctly. Export everything, change a document type value and export again. It doesn't seem to export the new value. I will see if I can track down what is going wrong there.

@chrno1209
Copy link

when will this PR be merged and release please? this is the missing piece of Seo Toolkit :)

@krebil
Copy link
Author

krebil commented Jun 12, 2023

@chrno1209

It's hard to say honestly.
uSync is really made to sync umbraco nodes and SeoToolkits stores it's data in a custom table. So a lot of the out of the box functionality doesn't work for this integration.

@krebil
Copy link
Author

krebil commented Jun 12, 2023

@patrickdemooij9

Let me know if you need something from me, I'll be happy to jump on a call to squash the last bugs. Alternatively you can catch me at codegarden.

@tubbecool
Copy link

Would love to see this PR merged! uSync is amazing and there is so much Seo data that is handled so smooth with the SeoToolkit.

@robertjf
Copy link
Contributor

Just my 2c on this - the uSync functionality really needs to be a separate package, just like a deploy.contrib package would be (if/when we create it!). uSync isn't relevant on Cloud, and having it as a dependency here is too entangled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants