Fix minor issues with privilege dropping feature #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for providing a Patch for this minor issue. I will merge and Tag it as Release after checking on it. Thanks again for contributing. |
|
I checked the code and think this will solve the issue. However dropping privileges on MacOS seams to lead to a bug where a user then cannot access the directory anymore. (Example: Running as root to bind port 80 and then drop to user patrick in a directory where patrick should be able to read - leads to not able to access the directory anymore. However this needs to be investigated separately). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues I mentioned in this comment. Tested working on FreeBSD with file-provided TLS certs.