Replace the rest of the hardcoded references to amd64 with {{ go_arch }}

[mkeesey]

Thank you for writing this role - it saved me a bunch of time writing my own.

I've updated the install tasks to use {{ go_arch}} instead of amd64 directly. This should match how the binaries are downloaded - I followed the pattern used in #22.

I have a pi and an old debian-running macbook I ran this updated version against and it appears to successfully install and run promtail on both of the hosts.

[patrickjahns]

Would it make sense to remove {{ go_arch }} from the binary itself ?

[patrickjahns]

would it make sense to shorten the path to

Suggested change

	path: "{{ promtail_install_dir }}/{{ promtail_version }}/promtail-linux-{{ go_arch }}"
	path: "{{ promtail_install_dir }}/{{ promtail_version }}/promtail"

[patrickjahns]

Suggested change

	creates: "{{ promtail_install_dir }}/{{ promtail_version }}/promtail-linux-{{ go_arch }}"
	creates: "{{ promtail_install_dir }}/{{ promtail_version }}/promtail"

[patrickjahns]

Suggested change

	src: "{{ promtail_install_dir }}/{{ promtail_version }}/promtail-linux-{{ go_arch }}"
	src: "{{ promtail_install_dir }}/{{ promtail_version }}/promtail"

[patrickjahns]

@mkeesey
Thank you very much for the PR and please excuse the delay in review.
The change itself makes sense - I am wondering if it would make sense to completely remove the notion of architecture from the binary itself? What do you think/suggest?

Let me know and I merge the PR and create a new release :-)

[mkeesey]

@mkeesey
Thank you very much for the PR and please excuse the delay in review.
The change itself makes sense - I am wondering if it would make sense to completely remove the notion of architecture from the binary itself? What do you think/suggest?

Let me know and I merge the PR and create a new release :-)

No problem at all! Thanks for taking a look.

I think a lot of the necessity of the architecture-specific name comes down to the unzip process - the Grafana folks package the binary within the zip itself with OS and architecture specific names. Annoyingly, I haven't found a reasonable way to transform the filenames within the zip as they are extracted from promtail-$OS-$arch to a standard name like promtail. We could do a copy or move step afterwards so that the existence check at the beginning and the symlinking stage can use the base name, but it seems simpler to me to stay with the convention the upstream packagers use so we don't have to worry about multiple stages of checking if we need to do an operation.

I'm definitely ok with playing around with it some more if you want to iterate on the design a bit. 👍

[patrickjahns]

Thanks for your explanation 👍

but it seems simpler to me to stay with the convention the upstream packagers use so we don't have to worry about multiple stages of checking if we need to do an operation.

Agreed - I'll merge the PR and create a new release. Thank you very much for your efforts