Prepackaged option serializer #1
Conversation
| case None => JsNull | ||
| case Some(a) => innerFormat.writes(a) | ||
| } | ||
| ) |
There was a problem hiding this comment.
Ofc this breaks down if the innerFormat serializer also can return JsNull for some As. Not sure we care though - "if it hurts, don't do that"
| // box should pick up the implicit serializer? | ||
| import Serializers.Implicits._ | ||
|
|
||
| val serializer = Json.format[Box] |
There was a problem hiding this comment.
So here the macro pulls in the implicit option serializer for us.
patriknw
force-pushed
the
wip-docs-PersistentEntity-patriknw
branch
from
4246bd0
to
f872dd6
Compare
| * Implicitly provided serializers | ||
| */ | ||
| object Implicits { | ||
| implicit def optionFormat[A](implicit innerFormat: Format[A]): Format[Option[A]] = |
There was a problem hiding this comment.
could this be implicit class ... extends AnyVal?
(not important since it's not in any hot path)
There was a problem hiding this comment.
You mean that I would create a value class that implements the trait Format rather than this implicit conversion? Format seems to be "universal" so I guess maybe it could work, but we are anyways building up a graph of Format objects to do serialization so I don't think it is worth the effort to look into.
There was a problem hiding this comment.
yes, I was thinking about the wrong thing
|
I'll close this and PR against lagom master instead. |
No description provided.