Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with yedis #57

Closed
devthejo opened this issue May 14, 2021 · 6 comments
Closed

compatibility with yedis #57

devthejo opened this issue May 14, 2021 · 6 comments

Comments

@devthejo
Copy link

Hello @p3x-robot,
I'm trying to make redis-ui work with YEDIS from Yugabyte (an open-source cloud ready scalable PG and REDIS plateform).
There are few differences between REDIS and YEDIS, one of theses are the client command that is not supported yet.
Command client not yet supported. Arguments: [client, setname, ioredis-cluster(refresher)]
Related to yugabyte/yugabyte-db#985
I was wondering if there was possible to make the call to this command optional in redis-ui, or as a compatibility with Yedis option. What do you think ?

@p3x-robot
Copy link
Member

PR welcome, it is the about 5th based on redis. i only work with original redis. i doubt i will implement/fix protocol all 1000 redis clones.

@p3x-robot p3x-robot added help wanted Extra attention is needed low priority labels May 14, 2021
@devthejo
Copy link
Author

OK, got it. I thought it was like options "Azure Redis" or something. I will try to add an option, maybe "Retrieve Client Info" in "Edit connection" panel.

@p3x-robot
Copy link
Member

it is too much clones here. i think the clones should implement these functions, not me. sorry

@devthejo
Copy link
Author

I understand and I agree.
I requested yugabyte-db too, but it seems simpler to me to make a PR for redis-ui.
For info, I'm moving from redis cluster to yedis because it solve many problem almost automagically when it come to scale (as far as I know it's the only solution that does).

@p3x-robot
Copy link
Member

i work on simple redis deployment with multiple clients (this is erp, so no need to scale, deployments for a company or a webshop etc) and this p3x-redis-ui is satisfying to use it. i tried to help with other clones but lost count and this program is basically only for redis.... in the last week this is the 2nd clone i face, the other is tendis, same problem this and that functions is not implmeneted and my program would crash i do not want to work on this etc.... so very sorry. pr is welcome.

@devthejo
Copy link
Author

I've worked few hours trying to make redis-ui compatible but there are too many problem for now with yedis: scan is not supported (and as you know relying on keys is dangerous), even type command is not supported, so as far as I understand now, the only way to work with yedis is with console. Too bad, ysql seem to be fully compatible with postgresql, I was expecting it will be the same, or almost for yedis with redis, but we'll have to wait for that.
So I close the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants